popover: pop down when pressing escape
authorErnestas Kulik <ernestask@src.gnome.org>
Thu, 3 Nov 2016 10:58:41 +0000 (12:58 +0200)
committerErnestas Kulik <ernestask@src.gnome.org>
Thu, 3 Nov 2016 13:46:04 +0000 (15:46 +0200)
Simply hiding the popover may introduce inconsistencies in application
behavior, since popping up/down is the usual use case.

https://bugzilla.gnome.org/show_bug.cgi?id=773885

gtk/gtkpopover.c

index 9cbe815f540f044a6345f56ffc1ada7d28999613..b349f2ab7fb794cdb0abd07adbaccba347c9fe9c 100644 (file)
@@ -1461,7 +1461,7 @@ gtk_popover_key_press (GtkWidget   *widget,
 
   if (event->keyval == GDK_KEY_Escape)
     {
-      gtk_widget_hide (widget);
+      gtk_popover_popdown (GTK_POPOVER (widget));
       return GDK_EVENT_STOP;
     }